Kontinuation commented on code in PR #687:
URL: https://github.com/apache/sedona-db/pull/687#discussion_r2885357794
##########
sedona-cli/src/main.rs:
##########
@@ -66,15 +66,14 @@ struct Args {
#[clap(
short = 'm',
long,
- help = "The memory pool limitation (e.g. '10g'), default to None (no
limit)",
- value_parser(extract_memory_pool_size)
+ help = "The memory pool limitation (e.g. '10g'), default to 75% of
physical memory. Use 'unlimited' to disable"
)]
- memory_limit: Option<usize>,
+ memory_limit: Option<String>,
Review Comment:
Restored Clap-side validation for --memory-limit by introducing the
`MemoryLimitArg` enum and `parse_memory_limit()` function used as Clap
value_parser.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
