paleolimbot commented on code in PR #648:
URL: https://github.com/apache/sedona-db/pull/648#discussion_r2867031475
##########
rust/sedona-pointcloud/src/options.rs:
##########
@@ -80,7 +80,9 @@ extensions_options! {
pub struct PointcloudOptions {
pub geometry_encoding: GeometryEncoding, default =
GeometryEncoding::default()
pub collect_statistics: bool, default = false
+ pub parallel_statistics_extraction: bool, default = false
pub persist_statistics: bool, default = false
+ pub round_robin_partitioning: bool, default = false
Review Comment:
All of these would benefit from a brief summary docstring of when these
values should be modified (e.g., use round robin partitioning when running
queries with selective workloads that benefit from parallelization).
##########
rust/sedona-pointcloud/src/las/source.rs:
##########
@@ -149,6 +152,40 @@ impl FileSource for LasSource {
self.extension.as_str()
}
+ fn repartitioned(
+ &self,
Review Comment:
Can you add some of the text you have in this PR to this section so that
future readers have some background on why this is necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
