paleolimbot commented on PR #650: URL: https://github.com/apache/sedona-db/pull/650#issuecomment-3939997418
> Would it be better called sd_simplify_storage to be more consistent with the naming in st functions, such as st_force_dim, st_line_merge? The naming of this is consistent with our other internal functions like `sd_format()` and `sd_order()` that aren't intended to be user facing (inserted by internals). > Do we consider lazy evaluation, or does this materialize the entire dataset immediately as what datafusion cast operations? This is a great point...in many cases we could avoid the function call altogether, or perhaps the entire projection if there are no types that need simplifying. If we use this for anything other than export to a record batch reader we could consider this. For this use case I think it is OK (an arrow cast for an identical storage type is just an Arc clone). This doesn't materialize anything (just pushes a function call as a projection). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
