Kontinuation commented on code in PR #566:
URL: https://github.com/apache/sedona-db/pull/566#discussion_r2762003977
##########
rust/sedona-geo-generic-alg/src/algorithm/line_measures/metric_spaces/euclidean/utils.rs:
##########
@@ -1571,28 +1571,28 @@ mod tests {
}
}
- #[test]
- fn test_random_linestring_to_linestring_distance() {
- // Test linestring-to-linestring distance with random inputs
- for i in 0..100 {
- let seed1 = 77777 + i * 59;
- let seed2 = 88888 + i * 61;
-
- let ls1 = generate_random_linestring(seed1, 3 + (i % 3) as usize);
// 3-5 points
- let ls2 = generate_random_linestring(seed2, 3 + ((i + 1) % 3) as
usize); // 3-5 points
-
- let concrete_dist = Euclidean.distance(&ls1, &ls2);
- // Use our actual generic implementation via
nearest_neighbour_distance
- let generic_dist = nearest_neighbour_distance(&ls1, &ls2);
-
- assert_relative_eq!(
- concrete_dist,
- generic_dist,
- epsilon = 1e-10,
- max_relative = 1e-10
- );
- }
- }
+ // #[test]
+ // fn test_random_linestring_to_linestring_distance() {
+ // // Test linestring-to-linestring distance with random inputs
+ // for i in 0..100 {
+ // let seed1 = 77777 + i * 59;
+ // let seed2 = 88888 + i * 61;
+
+ // let ls1 = generate_random_linestring(seed1, 3 + (i % 3) as
usize); // 3-5 points
+ // let ls2 = generate_random_linestring(seed2, 3 + ((i + 1) % 3)
as usize); // 3-5 points
+
+ // let concrete_dist = Euclidean.distance(&ls1, &ls2);
+ // // Use our actual generic implementation via
nearest_neighbour_distance
+ // let generic_dist = nearest_neighbour_distance(&ls1, &ls2);
+
+ // assert_relative_eq!(
+ // concrete_dist,
+ // generic_dist,
+ // epsilon = 1e-10,
+ // max_relative = 1e-10
+ // );
+ // }
+ // }
Review Comment:
Preliminary investigations indicate that our calculations are correct, and
geo 0.32.0 is incorrect.
I'll look into it further and see if I can submit a patch to georust/geo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
