Kontinuation opened a new pull request, #2607:
URL: https://github.com/apache/sedona/pull/2607

   ## Did you read the Contributor Guide?
   
   - Yes, I have read the [Contributor 
Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor 
Development Guide](https://sedona.apache.org/latest/community/develop/)
   
   - No, I haven't read it.
   
   ## Is this PR related to a ticket?
   
   - Yes, and the PR name follows the format `[SEDONA-XXX] my subject`.
   - Yes, and the PR name follows the format `[GH-XXX] my subject`. Closes #2603
   
   - No:
     - this is a documentation update. The PR name follows the format `[DOCS] 
my subject`
     - this is a CI update. The PR name follows the format `[CI] my subject`
   
   ## What changes were proposed in this PR?
   
   `ST_AreaSpheroid`/`Spheroid.area` previously computed spheroidal area for a 
`Polygon` by feeding `geom.getCoordinates()` into GeographicLib `PolygonArea`, 
which flattens exterior + interior rings and can yield incorrect results for 
polygons with holes / complex geometries.
   
   This PR computes area as exterior ring area minus the sum of interior ring 
areas (holes), by computing each ring independently.
   
   ## How was this patch tested?
   
   - `mvn -pl common test`
   
   ## Did this PR include necessary documentation updates?
   
   - No, this PR does not affect any public API so no need to change the 
documentation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to