petern48 commented on PR #556:
URL: https://github.com/apache/sedona-db/pull/556#issuecomment-3808574888
As you wait for a proper review, I'll suggest that you consider breaking
this into multiple PRs. It looks like you described 4 separate changes (the
bullets) that would tend nicely to at least 4 isolated PRs. I know it's more
work for you, but it reduces the review burden significantly, as reviewers
don't need to figure out which of the 4 bullets a particular code change
applies to.
You can always base branches off of each other to reuse work from your other
branches. Something like below, or however you see fit.
```
Header Renaming -> MemoryManager -> RelateEngine
\
\---> ParallelWkbLoader
(this is a random example, i didn't actually look into it that much)
```
Doing a separate PR for Header Renaming and straightforward changes would
cut down the 88-file diff significantly, and could even be reviewed by people
with less context about GPU join (like me).
Separate PRs could help your changes land faster, and help with future
debugging / understanding when someone tries to figure out what happened. WDYT?
Would breaking this up be reasonable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
