Kontinuation commented on code in PR #535:
URL: https://github.com/apache/sedona-db/pull/535#discussion_r2719780471
##########
rust/sedona-functions/src/executor.rs:
##########
@@ -383,6 +383,20 @@ impl ScalarGeo for ScalarValue {
| ScalarValue::BinaryView(maybe_item)
| ScalarValue::LargeBinary(maybe_item) =>
Ok(maybe_item.as_deref()),
ScalarValue::Null => Ok(None),
+ ScalarValue::Struct(s)
+ if s.fields().len() == 2
+ && s.fields()[0].name() == "item"
+ && s.fields()[1].name() == "crs" =>
Review Comment:
If I remember it correctly, this pattern for decomposing fields in struct
type representing item with crs has appeared many times in the code base. Maybe
we can define a helper method for doing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
