2010YOUY01 commented on PR #533:
URL: https://github.com/apache/sedona-db/pull/533#issuecomment-3782521394
Thank you for the review.
> I think sometimes we do:
>
> ```python
> with pytest.raises(lib.SedonaError, match="foofy"):
> eng.execute_and_collect("SELECT ...")
> ```
>
> Would that work here? If not I think it is OK to skip this check for now.
Yes it works, applied in
[3524859](https://github.com/apache/sedona-db/pull/533/commits/35248596225206e2bae4ebaa25d53e1ee2e81f75)
I was thinking wrapping such raises syntax with something like
```
eng.assert_query_error("select foo()", Exception, "Function did not exist")
```
To make error assertion slightly more ergonomic, should we do this as follow
up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
