paleolimbot commented on code in PR #495:
URL: https://github.com/apache/sedona-db/pull/495#discussion_r2666965430


##########
r/sedonadb/R/000-wrappers.R:
##########


Review Comment:
   Thanks! I changed this to use .lintr.R instead for the day we need more 
complex rules 🚀 
   
   We have to modify the R wrappers anyway (because of licenses and because of 
the two blank lines at the end of the file), and we need a shell script anyway 
(because of the license files and pre-commit), so it's just as easy to keep it 
in for now. It's a good tip and we can circle back if this gets in the way (I 
think I can move the generated-by comment to the first line without the license 
checker getting mad in a pinch).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to