petern48 commented on PR #493:
URL: https://github.com/apache/sedona-db/pull/493#issuecomment-3716708596

   Seems like there's an upstream bug, in `geos` where `.simplify()` adds a Z 
dimension when processing `POINT EMPTY` or `LINESTRING EMPTY`. This was causing 
[rust](https://github.com/apache/sedona-db/actions/runs/20763714948/job/59624864044?pr=493)
 and [Python 
tests](https://github.com/apache/sedona-db/actions/runs/20763714895/job/59624864115?pr=493)
 to fail now that write_geos_geometry() actually writes the Z dimension, unlike 
before.
   
   <details>
   <summary>
   Debug output:
   </summary>
   
   ```
   input geometry: "LINESTRING EMPTY"
   initial_type LineString. post_geometry_type LineString
   raw geometry after simplify(): "LINESTRING Z EMPTY"
   geometry after post-processing: LINESTRING Z EMPTY
   ```
   
   ```
   input geometry: "POINT EMPTY"
   initial_type Point. post_geometry_type Point
   raw geometry after simplify(): "POINT Z EMPTY"
   geometry after post-processing: POINT Z EMPTY
   ```
   </details>
   
   There's also a [test 
failure](https://github.com/apache/sedona-db/actions/runs/20763714948/job/59624864044?pr=493)
 in the Rust ST_Snap tests. I see it has the same problem of adding Z 
dimensions to `POINT EMPTY` and `LINESTRING EMPTY`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to