yutannihilation commented on code in PR #449:
URL: https://github.com/apache/sedona-db/pull/449#discussion_r2616694139
##########
rust/sedona-functions/src/st_setsrid.rs:
##########
@@ -274,8 +274,11 @@ impl SedonaScalarKernel for SRIDifiedKernel {
let crs = match scalar_args[orig_args_len] {
Some(crs) => crs,
- None => return Ok(None),
+ // If the SRID is not a literal, fall back to the inner result
without applying a CRS.
+ // This allows planning to succeed when the SRID is provided as a
column or expression.
+ None => return Ok(Some(inner_result)),
};
Review Comment:
(Sorry, I just forgot `.return_type()` doesn't work)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
