Abeeujah commented on PR #431: URL: https://github.com/apache/sedona-db/pull/431#issuecomment-3647306898
> If we'd like to keep this implementation in the PR (which I think is great!), we need one test for every branch you have in the implementation (which here would be one for every geometry type plus the empty point). Testing all the empties is probably a good thing to do, too. It was panic-ing for Empty Points, Empty Points in Multi-Points and a GeometryCollection, I didn't exactly have a fix for it, and didn't want it getting in the way. > I see you removed the geo-based implementation...happy to review if you're ever in the mood to re-add! Would open up another PR for the geo-based implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
