Kontinuation commented on code in PR #362:
URL: https://github.com/apache/sedona-db/pull/362#discussion_r2608835924
##########
rust/sedona-common/src/option.rs:
##########
@@ -64,6 +64,10 @@ config_namespace! {
/// The execution mode determining how prepared geometries are used
pub execution_mode: ExecutionMode, default =
ExecutionMode::Speculative(DEFAULT_SPECULATIVE_THRESHOLD)
+ /// Collect build side partitions concurrently (using spawned tasks).
+ /// Set to false for JNI/embedded contexts without async runtime
support.
+ pub concurrent_build_side_collection: bool, default = true
Review Comment:
As I mentioned in another PR, concurrent build side collection does not work
for Comet not because of it does not have async runtime support. The
`build_index` function is async so we always need async runtime support.
##########
rust/sedona-spatial-join/src/exec.rs:
##########
@@ -107,7 +107,7 @@ fn determine_knn_build_probe_plans<'a>(
/// 2. **Probe Phase**: Each geometry from the right table is used to query
the spatial index
/// 3. **Refinement**: Candidate pairs from the index are refined using exact
spatial predicates
/// 4. **Output**: Matching pairs are combined according to the specified join
type
-#[derive(Debug)]
+#[derive(Debug, Clone)]
pub struct SpatialJoinExec {
Review Comment:
Making an ExecutionPlan `Clone` is quite unusual. The other execution plans
in DataFusion are not `Clone` and they still integrate well with other systems
such as Comet. Is there any specific reasons for doing this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
