jesspav commented on PR #430: URL: https://github.com/apache/sedona-db/pull/430#issuecomment-3634130414
> For the case of the Crs, I _think_ you can just return a clone of that column (i.e., you shouldn't need to peek into the values at all, just clone the `ArrayRef`!) I did consider just spitting out the same thing as we read as that would definitely be very fast, but I thought that it would create odd inconsistencies. For example, if you set a raster's CRS to 'EPSG:4326' it would spit that out. If you transform a raster to 'EPSG:4326' then its CRS would be 'OGC:CRS84'. Maybe that doesn't matter. Either way, when we run functions like intersects we are going to need to ask if the raster with 'EPSG:4326' has the same CRS as the raster/geo with CRS 'OGC:CRS84' (after doing a fast string equality check that will fail), so having a CRS cache is still going to be important. I have some nice flamegraphs that are pointing to quite a few additional opportunities. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
