Copilot commented on code in PR #405:
URL: https://github.com/apache/sedona-db/pull/405#discussion_r2582619086
##########
rust/sedona-raster-functions/src/rs_worldcoordinate.rs:
##########
@@ -77,6 +90,19 @@ fn rs_rastertoworldcoordx_doc() -> Documentation {
.build()
}
+fn rs_rastertoworldcoord_doc() -> Documentation {
+ Documentation::builder(
+ DOC_SECTION_OTHER,
+ "Returns the grid coordinate of the given world coordinates as a
Point.".to_string(),
+ "RS_RasterToWorldCoord(raster: Raster, x: Integer, y:
Integer)".to_string(),
+ )
+ .with_argument("raster", "Raster: Input raster")
+ .with_argument("x", "Integer: Column x into the raster")
+ .with_argument("y", "Integer: Row y into the raster")
Review Comment:
[nitpick] The parameter descriptions use inconsistent terminology. The first
parameter is described as 'Column x' while the second is 'Row y'. Consider
using consistent terminology such as 'x coordinate (column)' and 'y coordinate
(row)' to match the existing `RS_RasterToWorldCoordX` and
`RS_RasterToWorldCoordY` documentation patterns.
##########
rust/sedona-raster-functions/src/rs_worldcoordinate.rs:
##########
@@ -77,6 +90,19 @@ fn rs_rastertoworldcoordx_doc() -> Documentation {
.build()
}
+fn rs_rastertoworldcoord_doc() -> Documentation {
+ Documentation::builder(
+ DOC_SECTION_OTHER,
+ "Returns the grid coordinate of the given world coordinates as a
Point.".to_string(),
Review Comment:
The documentation description is inconsistent with the function's behavior.
It states 'Returns the grid coordinate of the given world coordinates' but
should say 'Returns the world coordinate of the given grid coordinates' since
the function converts from pixel/grid coordinates to world coordinates.
```suggestion
"Returns the world coordinate of the given grid coordinates as a
Point.".to_string(),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
