paleolimbot commented on code in PR #375:
URL: https://github.com/apache/sedona-db/pull/375#discussion_r2567192626
##########
dev/release/verify-release-candidate.sh:
##########
@@ -262,8 +262,6 @@ test_python() {
show_info "Installing Python package"
rm -rf "${SEDONADB_TMPDIR}/python"
- # Keep this export in sync with the export in .github/workflows/python.yml
- export MATURIN_PEP517_ARGS="--features s2geography"
Review Comment:
@petern48 I moved this into the verification instructions instead of the
default behaviour (i.e., MacOS users or exceptionally above-and-beyond voters
can try this) because in some of my testing on Linux the Python build failed.
We use CI to ensure this works where we need it to (arbitrary computers are
hard!)
##########
python/sedonadb/tests/functions/test_order.py:
##########
@@ -17,9 +17,14 @@
import geopandas
import geopandas.testing
+import pytest
+import sedonadb
def test_order_sql(con):
+ if "s2geography" not in sedonadb.__features__:
+ pytest.skip("Ordering currently requires build with feature
s2geography")
Review Comment:
This is needed so that the tests pass without the s2geography feature, which
is currently required for ordering
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
