paleolimbot commented on code in PR #363:
URL: https://github.com/apache/sedona-db/pull/363#discussion_r2561321958
##########
rust/sedona-functions/benches/native-functions.rs:
##########
@@ -147,6 +147,9 @@ fn criterion_benchmark(c: &mut Criterion) {
),
);
+ benchmark::scalar(c, &f, "native", "st_reverse", Polygon(10));
+ benchmark::scalar(c, &f, "native", "st_reverse", MultiPoint(10));
Review Comment:
> I think using the lib name is causing the bench util to not compare them
That is intentional...if you have the benchmark name be the same then the
benchmark harness gets confused and it's easy to make a mistake/hard to know
what exactly you just benchmarked. I don't think it's too bad to do the math
ourselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
