petern48 commented on PR #2512: URL: https://github.com/apache/sedona/pull/2512#issuecomment-3573577084
Documenting the failures from the test_match_geopandas tests Error for LinearRing: ``` ValueError: Geometry equality check failed for LINESTRING Z (0 0 4, 1 0 4, 1 1 4, 0 1 4, 0 0 4) and LINEARRING Z (0 0 4, 1 0 4, 1 1 4, 0 1 4, 0 0 4) ``` Yep this is fine to skip. Sedona is returning the equivalent as a LineString. ✅ Error for MultiPolygon: ``` ValueError: Geometry equality check failed for POLYGON Z ((0 0 4, 0 1 4, 1 0 4, 0 0 4), (0.1 0.1 4, 0.1 0.2 4, 0.2 0.1 4, 0.1 0.1 4)) and MULTIPOLYGON Z (((0 0 4, 0 1 4, 1 0 4, 0 0 4), (0.1 0.1 4, 0.1 0.2 4, 0.2 0.1 4, 0.1 0.1 4)) ``` Ah interesting, it's the same geometry, but we return polygon instead of multipolygon. I dug in an submitted a fix for this: https://github.com/apache/sedona/pull/2526 Trying it on PostGIS, I see returning MultiPolygon is the desired behavior as well ``` SELECT ST_AsText(ST_Force3D(ST_GeomFromText('MULTIPOLYGON(((0 0, 0 1, 1 0, 0 0), (0.1 0.1, 0.1 0.2, 0.2 0.1, 0.1 0.1)))'), 4)); -- MULTIPOLYGON Z (((0 0 4,0 1 4,1 0 4,0 0 4),(0.1 0.1 4,0.1 0.2 4,0.2 0.1 4,0.1 0.1 4))) ``` Error for GeometryCollection ``` ValueError: Geometry equality check failed for GEOMETRYCOLLECTION Z (MULTIPOINT Z ((0 0 4), (1 1 4)), MULTILINESTRING Z ((0 0 4, 1 1 4), (2 2 4, 3 3 4)), POLYGON Z ((0 0 4, 0 1 4, 1 0 4, 0 0 4), (0.1 0.1 4, 0.1 0.2 4, 0.2 0.1 4, 0.1 0.1 4))) and GEOMETRYCOLLECTION Z (MULTIPOINT Z ((0 0 4), (1 1 4)), MULTILINESTRING Z ((0 0 4, 1 1 4), (2 2 4, 3 3 4)), MULTIPOLYGON Z (((0 0 4, 0 1 4, 1 0 4, 0 0 4), (0.1 0.1 4, 0.1 0.2 4, 0.2 0.1 4, 0.1 0.1 4)))) ``` Fails for the same reason as multipolygon (since it has a multipolygon inside of it). Error for M coordinates. Hmm, yeah this one is interesting. Give me a bit more time to figure out what to do here. ``` # For POINT M (1 2 3) input ValueError: Geometry equality check failed for POINT Z (1 2 7.5) and POINT M (1 2 3) # For POINT ZM (1 2 3 4) input ValueError: Geometry equality check failed for POINT Z (1 2 3) and POINT Z (1 2 7.5) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
