paleolimbot commented on code in PR #302:
URL: https://github.com/apache/sedona-db/pull/302#discussion_r2529532611
##########
rust/sedona/Cargo.toml:
##########
@@ -70,6 +70,7 @@ sedona-geometry = { path = "../sedona-geometry" }
sedona-geoparquet = { path = "../sedona-geoparquet" }
sedona-geos = { path = "../../c/sedona-geos", optional = true }
sedona-proj = { path = "../../c/sedona-proj", default-features = false }
+sedona-raster-functions = { path = "../../rust/sedona-raster-functions",
default-features = true }
Review Comment:
```suggestion
sedona-raster-functions = { path = "../../rust/sedona-raster-functions" }
```
(I think default features are always included if this is unspecified?)
##########
rust/sedona-raster-functions/src/rs_size.rs:
##########
@@ -99,28 +141,41 @@ mod tests {
let udf: ScalarUDF = rs_width_udf().into();
assert_eq!(udf.name(), "rs_width");
assert!(udf.documentation().is_some());
+
+ let udf: ScalarUDF = rs_height_udf().into();
+ assert_eq!(udf.name(), "rs_height");
+ assert!(udf.documentation().is_some());
}
- #[test]
- fn udf_invoke() {
+ #[rstest]
+ fn udf_invoke(#[values(SizeType::Width, SizeType::Height)] st: SizeType) {
+ let kernel = RsSize {
+ size_type: st.clone(),
+ };
Review Comment:
No need to do it in this PR, but before we get too far we should ensure that
the `ScalarUdfTester` can handle raster inputs and results (this would cut down
quite a bit on the verbosity of this and future tests)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
