petern48 commented on code in PR #2421:
URL: https://github.com/apache/sedona/pull/2421#discussion_r2507637493
##########
python/tests/geopandas/test_geoseries.py:
##########
@@ -112,7 +111,7 @@ def test_to_spark_pandas(self):
crs = "EPSG:3857"
result = GeoSeries(data, index=index, crs=crs).to_spark_pandas()
ps_df = ps.Series(data, index=index)
- assert_series_equal(result.to_pandas(), ps_df.to_pandas())
+ self.check_pd_series_equal(result, ps_df)
Review Comment:
```suggestion
self.check_pd_series_equal(result, ps_df.to_pandas())
```
Got to be careful here. This is what caused the test failure.
`self.check_pd_series_equal()` takes a `ps.Series` for the first arg and a
`pd.Series` for the second. Here, by removing the `.to_pandas()` call from
both, you tried inputting a `ps.Series` and `ps.Series`.
I suggested a change that should fix it. Again, I recommend setting up your
local dev environment using the link I sent above and running the tests locally
(at least the tests that you changed). For more interesting PRs, you really
wouldn't have a good time having to wait for a maintainer to trigger CI to run
to see if your tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
