paleolimbot commented on code in PR #237:
URL: https://github.com/apache/sedona-db/pull/237#discussion_r2466776516
##########
rust/sedona/src/show.rs:
##########
@@ -495,6 +496,7 @@ impl DisplayColumn {
arg_fields,
number_rows: array.len(),
return_field,
+ config_options: Arc::new(ConfigOptions::default()),
Review Comment:
This is a place where we should really pipe in the actual config options. I
think we have a reference this a few levels up, but if it's too hard feel free
to open up a follow-up ticket (and link to it in a comment here).
##########
rust/sedona-geoparquet/Cargo.toml:
##########
@@ -46,6 +46,7 @@ chrono = { workspace = true }
datafusion = { workspace = true, features = ["parquet"] }
datafusion-catalog = { workspace = true }
datafusion-common = { workspace = true }
+datafusion-datasource-parquet = "50.2.0"
Review Comment:
```suggestion
datafusion-datasource-parquet = { workspace = true }
```
(...and add this to the top-level Cargo.toml)
##########
rust/sedona-geoparquet/src/writer.rs:
##########
@@ -230,6 +232,7 @@ fn project_bboxes(
bbox_udf.clone(),
vec![column],
Arc::new(Field::new("", bbox_type(), true)),
+ Arc::new(ConfigOptions::default()),
Review Comment:
We're calling a very specific UDF here and so I think this is OK, but worth
at least adding a comment here that we could provide the real `ConfigOptions`
by piping the `Session` through here (we have a reference a few levels up).
##########
rust/sedona/src/show.rs:
##########
@@ -252,7 +252,8 @@ impl<'a> DisplayTable<'a> {
}
}
- table.set_truncation_indicator(self.truncation_indicator());
+ // TODO: set_truncation_indicator method was removed in comfy_table 7.x
+ // table.set_truncation_indicator(self.truncation_indicator());
Review Comment:
Feel free to open up a follow-up ticket and link to it in this comment if it
can't be solved here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
