petern48 commented on PR #241: URL: https://github.com/apache/sedona-db/pull/241#issuecomment-3447949345
Looking good so far to me. The biggest thing we're missing is Python integration tests. In case you write these up and find the current logic is flawed in *some* way (e.g we forgot/overlooked something), I recommend referencing [Sedona's parseBufferParams() function](https://github.com/apache/sedona/blob/d6ea87cf9f2a27adee00ff0fb41ee92002b9a834/common/src/main/java/org/apache/sedona/common/Functions.java#L311) and my previous [PR](https://github.com/apache/sedona/pull/2184) to fix it. I recall PostGIS's docs don't do the best job of explaining how default params are handled when certain values are specified. For example, I think we're missing [this logic](https://github.com/apache/sedona/blob/d6ea87cf9f2a27adee00ff0fb41ee92002b9a834/common/src/main/java/org/apache/sedona/common/Functions.java#L393-L402) at the moment (use python tests to check). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
