Abeeujah commented on code in PR #234:
URL: https://github.com/apache/sedona-db/pull/234#discussion_r2455037469
##########
python/sedonadb/python/sedonadb/testing.py:
##########
@@ -269,11 +269,74 @@ def assert_result(self, result, expected, **kwargs) ->
"DBEngine":
result_pandas = self.result_to_pandas(result)
pandas.testing.assert_frame_equal(result_pandas, expected,
**kwargs)
elif isinstance(expected, list):
- result_tuples = self.result_to_tuples(result, **kwargs)
- if result_tuples != expected:
- raise AssertionError(
- f"Expected:\n {expected}\nGot:\n {result_tuples}"
- )
+ result_table = self.result_to_table(result)
+ geom_cols_schema = _geometry_columns(result_table.schema)
+
+ if geom_cols_schema:
+ import shapely
Review Comment:
Hi @petern48 thank you so much for your suggestions as well, They were
invaluable, made me remember and better understand that every line of code is
technical debt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
