petern48 commented on code in PR #229:
URL: https://github.com/apache/sedona-db/pull/229#discussion_r2443372909
##########
c/sedona-geos/benches/geos-functions.rs:
##########
@@ -295,6 +295,20 @@ fn criterion_benchmark(c: &mut Criterion) {
"st_overlaps",
ArrayScalar(Polygon(10), Polygon(500)),
);
+ benchmark::scalar(
+ c,
+ &f,
+ "geos",
+ "st_isvalid",
+ ArrayScalar(Polygon(10), Polygon(10)),
Review Comment:
Yep! For benches, you can try running you can run `cargo bench -- <name
pattern>` while being in the correct directory.
For this case, you need to be in `cd c/sedona-geos/` and run `cargo bench --
st_isvalid`. This is documented
[here](https://github.com/apache/sedona-db/blob/3d756644caccd33d7a2bba41e646924caddd3203/docs/contributors-guide.md#running-benchmarks)
in the contributors guide (though tbh, they could be better since it doesn't
explain how to interpret them).
Personally, I don't run these myself locally unless I'm actually working on
optimizing performance. They generally work as long as you have the right
number of args and arg types (I've never seen them fail for other reasons). It
also takes over a minute just for one function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
