joonaspessi opened a new pull request, #231:
URL: https://github.com/apache/sedona-db/pull/231

   Hello!
   
   Thought that implementing something relatively simple from your [first issue 
proposal](https://github.com/apache/sedona-db/issues/224) would be a good way 
to understand how `sedona-db` works. Thanks for creating this project.
   
   This PR implements `ST_IsRing` with GEOS. 
   
   I did some research on how other spatial libraries handle this function when 
a non-LineString geometry is passed:
   
     | System | Non-LineString Behavior |
     |--------|------------------------|
     | **DuckDB spatial extensions** | Returns `false` |
     | **Apache Sedona** | Returns `false` |
     | **PostGIS** | Throws error  |
     | **This PR** | Returns `false`|
   
     I chose to follow the original Apache Sedona rather than PostGIS because 
it matches the existing Sedona ecosystem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to