petern48 commented on code in PR #171:
URL: https://github.com/apache/sedona-db/pull/171#discussion_r2403685319
##########
python/sedonadb/tests/functions/test_functions.py:
##########
@@ -481,8 +483,18 @@ def test_st_geomfromwkb(eng, geom):
("LINESTRING Z (0 0 0, 1 1 1)", True),
("POLYGON EMPTY", False),
("MULTIPOINT ((0 0), (1 1))", False),
+ ("MULTIPOINT Z ((0 0 0))", True),
+ # SedonaDB can't parse this yet:
https://github.com/apache/sedona-db/issues/162
+ # ("MULTIPOINT ((0 0 0))", True),
Review Comment:
Before testing it, I assumed you meant the outer dimension code would be xy
instead of xyz, but based on the script below, I get the same byte
representation as `MULTIPOINT Z ((0 0 0))` (type code 1004, xyz multipoint). Am
I missing something? What did you have in mind?
```python
# shapely 2.1.2
wkt = "MULTIPOINT Z ((1 1 1))"
geom = shapely.from_wkt(wkt)
byte_order = geom.wkb[0]
assert byte_order == 1
iso_bytes = shapely.to_wkb(geom, flavor="iso")
print(iso_bytes)
# adds a few spaces for readability
# 1 ec 03 00 00
0100000001e9030000000000000000f03f000000000000f03f000000000000f03f
# The type code `ec 03 00 00` translates to 1004 (an xyz multipoint)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
