petern48 commented on code in PR #24: URL: https://github.com/apache/sedona-db/pull/24#discussion_r2414077330
########## benchmarks/README.md: ########## @@ -79,3 +79,36 @@ test_st_buffer[collections_simple-PostGIS] 855.3329 (9.96) 854.7194 (9. ``` For more details and command line options, refer to the official [pytest-benchmark documentation](https://pytest-benchmark.readthedocs.io/en/latest/usage.html) + +### Adding New Benchmarks + +There are two categories of benchmarks, each mapped to a pytest marker: + +- `@pytest.mark.bench_udf`: + Micro / UDF benchmarks that measure the per-function cost (e.g. ST_Area, ST_Contains). These should run engines in a comparable, single-thread style configuration (where possible) to make function-level performance differences clearer. +- `@pytest.mark.bench_query`: + Macro / complex query benchmarks (e.g. KNN joins) that represent perceived end-user performance. Engines run with their default / natural configuration (multi-threading, internal parallelism, etc.). Review Comment: I like how you phrased it + very concise 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
