petern48 commented on code in PR #2378:
URL: https://github.com/apache/sedona/pull/2378#discussion_r2418135679
##########
python/tests/geopandas/test_match_geopandas_series.py:
##########
@@ -588,7 +588,11 @@ def test_is_ccw(self):
pass
def test_is_closed(self):
- pass
+ # is_closed is only meaningful for linestrings so we use
self.linestrings instead of self.geoms
Review Comment:
```suggestion
# is_closed is only meaningful for linestrings so we use
self.linestrings instead of self.geoms
if parse_version(gpd.__version__) < parse_version("1.0.0"):
pytest.skip("geopandas is_closed requires version 1.0.0 or
higher")
```
I think this should work.
I checked the changelog and `is_closed` wasn't added until gpd `1.0.0`, so
we just need to skip this test for the ci runs that use gpd < 1.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
