paleolimbot commented on code in PR #195: URL: https://github.com/apache/sedona-db/pull/195#discussion_r2414852016
########## rust/sedona-geo-generic-alg/src/algorithm/area.rs: ########## @@ -0,0 +1,621 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +use sedona_geo_traits_ext::*; + +use crate::{CoordFloat, CoordNum}; +use core::borrow::Borrow; + Review Comment: Much of these algorithms are copied from geo. Module level documentation along the lines of ``` //! Generic Area algorithm //! //! Ported (and contains copied code) from `geo::algorithm::area`: //! <https://github.com/georust/geo/blob/09eed85233f706d42fc27ac9f1494bd904a3b7a7/geo/src/algorithm/area.rs>. ``` (1) for licensing/IP clarity and (2) so that one could do a periodic review of the ported algorithms to see if any bugs were fixed upstream since the commit listed in the file. We can/should also acknowledge the source and license of this copied code in LICENSE (this is not quite a vendor but it is very similar and our other vendored code is listed there). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
