paleolimbot commented on code in PR #171:
URL: https://github.com/apache/sedona-db/pull/171#discussion_r2403696053
##########
python/sedonadb/tests/functions/test_functions.py:
##########
@@ -481,8 +483,18 @@ def test_st_geomfromwkb(eng, geom):
("LINESTRING Z (0 0 0, 1 1 1)", True),
("POLYGON EMPTY", False),
("MULTIPOINT ((0 0), (1 1))", False),
+ ("MULTIPOINT Z ((0 0 0))", True),
+ # SedonaDB can't parse this yet:
https://github.com/apache/sedona-db/issues/162
+ # ("MULTIPOINT ((0 0 0))", True),
Review Comment:
Given that it's this difficult to actually generate such well-known binary,
I'm not sure we have to handle this case. What you're up against here is that
you need the parser, the internal representation of the geometry (there: GEOS),
and the WKB writer to all support generating what is actually very fishy
output...most don't let you do that (so if you want to test this case, you're
going to have to hard-code the WKB yourself).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
