zhangfengcdt commented on code in PR #173:
URL: https://github.com/apache/sedona-db/pull/173#discussion_r2399286024
##########
rust/sedona-geoparquet/src/file_opener.rs:
##########
@@ -176,7 +218,10 @@ fn filter_access_plan_using_geoparquet_covering(
// Evaluate predicate!
if !spatial_filter.evaluate(&row_group_geo_stats) {
+ metrics.row_groups_spatial_pruned.add(1);
access_plan.skip(i);
Review Comment:
Should row_groups_spatial_pruned also be incremented for those skipped row
groups, or is that intentional to only count file-level pruning separately?
##########
rust/sedona-geoparquet/src/format.rs:
##########
@@ -364,15 +364,21 @@ impl GeoParquetFileSource {
predicate: Option<Arc<dyn PhysicalExpr>>,
) -> Result<Self> {
if let Some(parquet_source) =
inner.as_any().downcast_ref::<ParquetSource>() {
- let mut parquet_source = parquet_source.clone();
+ let parquet_source = parquet_source.clone();
// Extract the predicate from the existing source if it exists so
we can keep a copy of it
let new_predicate = match (parquet_source.predicate().cloned(),
predicate) {
(None, None) => None,
(None, Some(specified_predicate)) => Some(specified_predicate),
(Some(inner_predicate), None) => Some(inner_predicate),
- (Some(_), Some(specified_predicate)) => {
- parquet_source =
parquet_source.with_predicate(specified_predicate.clone());
- Some(specified_predicate)
+ (Some(inner_predicate), Some(specified_predicate)) => {
+ // Sanity check: predicate in `GeoParquetFileSource` is
init
+ // from its inner ParquetSource's predicate, they should be
+ // equivalent.
+ if Arc::ptr_eq(&inner_predicate, &specified_predicate) {
Review Comment:
This looks stricter than before. Could it break existing usage patterns?
worth to do a semantic equality check as well?
##########
rust/sedona/tests/metrics.rs:
##########
@@ -0,0 +1,97 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+use datafusion::arrow::util::pretty::pretty_format_batches;
+use sedona::context::SedonaContext;
+
+#[tokio::test]
+async fn geo_parquet_metrics() {
Review Comment:
Should the parquet specific test be in rust/sedona-geoparquet/tests/ instead
of rust/sedona/tests/ for better organization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
