paleolimbot commented on code in PR #150:
URL: https://github.com/apache/sedona-db/pull/150#discussion_r2379332717
##########
r/sedonadb/src/Makevars.in:
##########
@@ -40,7 +40,6 @@ $(STATLIB):
# therefore is only used if cargo is absent from the user's PATH.
export PATH="$(PATH):$(HOME)/.cargo/bin" && \
export CC="$(CC)" && \
- export CFLAGS="$(CFLAGS)" && \
Review Comment:
In general we really do want to pass CFLAGS here (for cross-compilation as
Hiroaki noted, but also for include flags passed from a user to workaround
build failures).
How about: `AWS_LC_SYS_CFLAGS=$(CFLAGS) -O0`?
https://github.com/aws/aws-lc-rs/blob/ee368e0689b2a0aee973e2d5be50a2c8d8b64374/aws-lc-sys/builder/main.rs#L144-L146
(If that doesn't work feel free to just remove it like you've done here and
I'll iterate on getting this to work)
##########
Cargo.lock:
##########
@@ -2652,7 +2653,7 @@ dependencies = [
[[package]]
name = "geo-traits"
version = "0.2.0"
-source =
"git+https://github.com/wherobots/geo.git?branch=generic-alg#a2a4d2d716f637da60eeb29731bd4415af784f76";
+source =
"git+https://github.com/wherobots/geo.git?branch=generic-alg#66ff85949a82549b0d28fb2d4fae01e3ea19ca83";
Review Comment:
I am guessing this is the fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
