Copilot commented on code in PR #149:
URL: https://github.com/apache/sedona-db/pull/149#discussion_r2379466434
##########
c/sedona-tg/src/tg_bindgen.rs:
##########
@@ -16,7 +16,51 @@
// under the License.
#![allow(non_upper_case_globals)]
#![allow(non_camel_case_types)]
-#![allow(non_snake_case)]
-#![allow(dead_code)]
-include!(env!("BINDINGS_PATH"));
+use std::os::raw::{c_char, c_void};
+
+#[cfg(target_env = "msvc")]
+use std::os::raw::c_int;
+
+#[cfg(target_env = "msvc")]
+pub type tg_index = c_int;
+
+#[cfg(not(target_env = "msvc"))]
+use std::os::raw::c_uint;
+
+#[cfg(not(target_env = "msvc"))]
+pub type tg_index = c_uint;
+
+pub const tg_index_TG_NONE: tg_index = 0;
+pub const tg_index_TG_DEFAULT: tg_index = 1;
Review Comment:
The constant values appear to be incorrect. Based on the removed bindings
file, TG_DEFAULT should be 0 and TG_NONE should be 1, but the current values
have them reversed.
```suggestion
pub const tg_index_TG_NONE: tg_index = 1;
pub const tg_index_TG_DEFAULT: tg_index = 0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
