Copilot commented on code in PR #34: URL: https://github.com/apache/sedona-spatialbench/pull/34#discussion_r2373689835
########## docs/single-node-benchmarks.md: ########## @@ -0,0 +1,104 @@ +--- +title: SpatialBench Single Node Benchmarks +--- + +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +This page presents the SpatialBench single-node benchmark results for SedonaDB, DuckDB, and GeoPandas. The benchmark was conducted on September 22, 2025, using SpatialBench v0.1.0 pre-release (commit 9094be8 on the main branch). + +Here are the results for v0.1 of the SpatialBench queries for scale factor 1 (SF1): + + + +Here are the results for SF10: + + + +The remainder of this document summarizes the hardware and software versions, query methodologies for specific engines, and provides information on where to find the benchmark code. + +## Hardware + +This benchmark was run on an AWS EC2 m7i.2xlarge instance, which has 8 CPUs and 32 GB of RAM. We encourage you to try running SpatialBench on different hardware configurations and share your results with the community. + +Below are the software versions used in this benchmark. + Review Comment: There is redundant text about software versions. Line 38 states 'Below are the software versions used in this benchmark' but the actual versions are listed after the 'Benchmark settings' heading on line 42. Consider removing the redundant statement on line 38. ```suggestion ``` ########## docs/single-node-benchmarks.md: ########## @@ -0,0 +1,104 @@ +--- +title: SpatialBench Single Node Benchmarks +--- + +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +This page presents the SpatialBench single-node benchmark results for SedonaDB, DuckDB, and GeoPandas. The benchmark was conducted on September 22, 2025, using SpatialBench v0.1.0 pre-release (commit 9094be8 on the main branch). + +Here are the results for v0.1 of the SpatialBench queries for scale factor 1 (SF1): + + + +Here are the results for SF10: + + + +The remainder of this document summarizes the hardware and software versions, query methodologies for specific engines, and provides information on where to find the benchmark code. + +## Hardware + +This benchmark was run on an AWS EC2 m7i.2xlarge instance, which has 8 CPUs and 32 GB of RAM. We encourage you to try running SpatialBench on different hardware configurations and share your results with the community. + +Below are the software versions used in this benchmark. Review Comment: There is redundant text about software versions. Line 38 states 'Below are the software versions used in this benchmark' but the actual versions are listed after the 'Benchmark settings' heading on line 42. Consider removing the redundant statement on line 38. ```suggestion ``` ########## docs/single-node-benchmarks.md: ########## @@ -0,0 +1,104 @@ +--- +title: SpatialBench Single Node Benchmarks +--- + +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +This page presents the SpatialBench single-node benchmark results for SedonaDB, DuckDB, and GeoPandas. The benchmark was conducted on September 22, 2025, using SpatialBench v0.1.0 pre-release (commit 9094be8 on the main branch). + +Here are the results for v0.1 of the SpatialBench queries for scale factor 1 (SF1): + + + +Here are the results for SF10: + + Review Comment: The image references lack alt text descriptions, which would improve accessibility for screen readers. Consider adding descriptive alt text such as `` and ``. ```suggestion  Here are the results for SF10:  ``` ########## docs/single-node-benchmarks.md: ########## @@ -0,0 +1,104 @@ +--- +title: SpatialBench Single Node Benchmarks +--- + +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +This page presents the SpatialBench single-node benchmark results for SedonaDB, DuckDB, and GeoPandas. The benchmark was conducted on September 22, 2025, using SpatialBench v0.1.0 pre-release (commit 9094be8 on the main branch). + +Here are the results for v0.1 of the SpatialBench queries for scale factor 1 (SF1): + + + +Here are the results for SF10: + + Review Comment: The image references lack alt text descriptions, which would improve accessibility for screen readers. Consider adding descriptive alt text such as `` and ``. ```suggestion  Here are the results for SF10:  ``` ########## docs/single-node-benchmarks.md: ########## @@ -0,0 +1,104 @@ +--- +title: SpatialBench Single Node Benchmarks +--- + +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +This page presents the SpatialBench single-node benchmark results for SedonaDB, DuckDB, and GeoPandas. The benchmark was conducted on September 22, 2025, using SpatialBench v0.1.0 pre-release (commit 9094be8 on the main branch). + +Here are the results for v0.1 of the SpatialBench queries for scale factor 1 (SF1): + + + +Here are the results for SF10: + + + +The remainder of this document summarizes the hardware and software versions, query methodologies for specific engines, and provides information on where to find the benchmark code. + +## Hardware + +This benchmark was run on an AWS EC2 m7i.2xlarge instance, which has 8 CPUs and 32 GB of RAM. We encourage you to try running SpatialBench on different hardware configurations and share your results with the community. + +Below are the software versions used in this benchmark. + Review Comment: There is redundant text about software versions. Line 38 states 'Below are the software versions used in this benchmark' but the actual versions are listed after the 'Benchmark settings' heading on line 42. Consider removing the redundant statement on line 38. ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
