paleolimbot commented on code in PR #117:
URL: https://github.com/apache/sedona-db/pull/117#discussion_r2366366291
##########
.github/workflows/r.yml:
##########
@@ -36,13 +36,17 @@ jobs:
test:
runs-on: ${{ matrix.config.os }}
name: ${{ matrix.config.os }} (${{ matrix.config.r }})
+ defaults:
+ run:
+ shell: bash
strategy:
fail-fast: false
matrix:
config:
- {os: ubuntu-latest, r: 'release'}
- {os: macos-latest, r: 'release'}
+ # - {os: windows-latest, r: 'release'}
Review Comment:
Can you open an issue to track adding this and link it here? (We do this for
most instances of commented-out code elsewhere in the project)
##########
.github/workflows/r.yml:
##########
@@ -63,6 +67,12 @@ jobs:
rustup toolchain install stable --no-self-update
rustup default stable
+ # GHA runnder installs GNU target by default, but --no-self-update might
Review Comment:
```suggestion
# GHA runner installs GNU target by default, but --no-self-update might
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
