zhangfengcdt commented on code in PR #53: URL: https://github.com/apache/sedona-db/pull/53#discussion_r2341213779
########## benchmarks/test_knn.py: ########## @@ -0,0 +1,225 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +import json +import pytest +from test_bench_base import TestBenchBase +from sedonadb.testing import SedonaDB + + +class TestBenchKNN(TestBenchBase): + def setup_class(self): + """Setup test data for KNN benchmarks""" + self.sedonadb = SedonaDB.create_or_skip() + + # Create building-like polygons (index side - fewer, larger geometries) + # Note: Dataset sizes are limited to avoid DataFusion CoalescePartitionsExec issues Review Comment: This is from issues I see when i was debugging into the Datafusion code and find when calling .collect() from python api, the CoalescePartitionsExec was triggered and caused OOM issues for very large test data sizes. It may not be a real "partition issue", but I assume CoalescePartitionsExec might have issues when combining so many small partitions in preparing the join data. It is an assumption though cause I cannot find real-world data to verify it. But yes, I've rephrased the comments to be more accurate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
