Kontinuation commented on code in PR #57:
URL: https://github.com/apache/sedona-db/pull/57#discussion_r2342861156
##########
python/sedonadb/tests/test_sjoin.py:
##########
@@ -76,3 +76,31 @@ def test_spatial_join(join_type, on):
sedonadb_results = eng_sedonadb.execute_and_collect(sql).to_pandas()
assert len(sedonadb_results) > 0
eng_postgis.assert_query_result(sql, sedonadb_results)
+
+
[email protected](reason="https://github.com/apache/sedona-db/issues/63";)
+def test_spatial_join_geography(geoarrow_data):
+ eng_sedonadb = SedonaDB.create_or_skip()
+ eng_postgis = PostGIS.create_or_skip()
+
+ eng_sedonadb.create_table_parquet(
+ "sjoin_geog_all",
+ geoarrow_data
+ / "natural-earth/files/natural-earth_countries-geography_geo.parquet",
+ )
+ test_data = eng_sedonadb.execute_and_collect(
+ "SELECT * FROM sjoin_geog_all LIMIT 100"
+ )
+ eng_sedonadb.create_table_arrow("sjoin_geog", test_data)
+ eng_postgis.create_table_arrow("sjoin_geog", test_data)
Review Comment:
I switched to using randomly generated data for this geography join test.
The bounds of generated data are disjoint on planar surface but intersects the
antimeridian on spherical surface. This distribution of data ensures that we
won't pass the test when handling geography objects as planar geometry objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
