zhangfengcdt commented on code in PR #65:
URL: https://github.com/apache/sedona-db/pull/65#discussion_r2342358494
##########
benchmarks/test_knn.py:
##########
@@ -89,138 +96,162 @@ def test_knn_performance(self, benchmark, k,
use_spheroid, dataset_size):
else:
trip_table = "knn_trips_small"
building_table = "knn_buildings"
- trip_limit = 500
+ trip_limit = 1000
- spheroid_str = "TRUE" if use_spheroid else "FALSE"
+ # Get the appropriate engine instance
+ eng = self._get_eng(engine)
Review Comment:
The _get_eng method is defined in test_bench_base.py:86 and available to all
benchmark classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
