paleolimbot commented on code in PR #26:
URL: https://github.com/apache/sedona-db/pull/26#discussion_r2325221197
##########
python/sedonadb/tests/functions/test_predicates.py:
##########
@@ -333,3 +328,32 @@ def test_st_within(eng, geom1, geom2, expected):
f"SELECT ST_Within({geom_or_null(geom1)}, {geom_or_null(geom2)})",
expected,
)
+
+
[email protected]("Skipping test for ST_Within with GeometryCollection")
Review Comment:
My preference would be to paste this test into a GitHub issue rather than a
skipped test (easier to find + fix and easier to differentiate from other
things that might be skipped). An xfail might also make it easier to
differentiate from things we skip because of missing dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
