Copilot commented on code in PR #2282:
URL: https://github.com/apache/sedona/pull/2282#discussion_r2284110791
##########
python/tests/geopandas/test_geopandas_base.py:
##########
@@ -33,6 +33,10 @@ class TestGeopandasBase(TestBase):
#
-----------------------------------------------------------------------------
# # Utils
#
-----------------------------------------------------------------------------
+ def setup_method(self):
+ # We enable this option by default for users, so we enable it by
default for testing for developers.
+ # This option is useful in testing to catch inefficiencies in the code
during development of geopandas.
Review Comment:
The comment on line 37 is confusing as it says 'we enable it by default for
testing' but the code sets it to False. The comment should clarify that this is
intentionally set to False for development testing to catch inefficiencies,
contrary to the user default.
```suggestion
# Although this option is enabled by default for users, we
intentionally set it to False during development testing
# to catch inefficiencies in the code when working with geopandas.
```
##########
python/tests/geopandas/test_geoseries.py:
##########
@@ -61,6 +61,7 @@ def setup_method(self):
),
]
)
+ super().setup_method()
Review Comment:
The `super().setup_method()` call should come before the test data setup,
not after. Moving it to the beginning ensures proper initialization order.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
