jiayuasu commented on code in PR #2275:
URL: https://github.com/apache/sedona/pull/2275#discussion_r2278235407
##########
common/src/main/java/org/apache/sedona/common/geography/Constructors.java:
##########
@@ -79,4 +83,185 @@ public static Geography geogFromGeoHash(String geoHash,
Integer precision) {
throw new RuntimeException(e);
}
}
+
+ public static Geometry geogToGeometry(Geography geography, int srid) {
+ int SRID = srid == geography.getSRID() ? srid : geography.getSRID();
Review Comment:
Please don't complicate the logic here. I suggest we only allow 1 signature
that is `geogToGeometry(Geography geography)`. The function always takes SRID
from the input geography.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
