zhangfengcdt opened a new pull request, #2274:
URL: https://github.com/apache/sedona/pull/2274

   ## Did you read the Contributor Guide?
   
   - Yes, I have read the [Contributor 
Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor 
Development Guide](https://sedona.apache.org/latest/community/develop/)
   
   ## Is this PR related to a ticket?
   
   - Yes, and the PR name follows the format `[GH-XXX] my subject`. Closes 
#<issue_number>
   
   ## What changes were proposed in this PR?
   
   Incorrect Class References
    - geoseries.py - Uses geopandas.GeoSeries.from_wkb() instead of Sedona's
   GeoSeries.from_wkb()
    - geoseries.py - Uses geopandas.GeoSeries.from_xy() instead of Sedona's 
GeoSeries.from_xy()
   - geodataframe.py - Uses geopandas.GeoDataFrame() instead of Sedona's 
GeoDataFrame()
   - geodataframe.py - Uses geopandas.read_file() instead of appropriate Sedona 
method
   
   Missing Import Statements
   - geoseries.py - Example uses pd.Series without import pandas as pd
   - geodataframe.py - Missing from sedona.spark.geopandas import GeoDataFrame
   
   Undefined Variables
   
   geoseries.py - Examples reference s.crs but s variable not defined in context
   geodataframe.py - Uses undefined filepath variable
   
   ## How was this patch tested?
   geopandas unit tests
   
   ## Did this PR include necessary documentation updates?
   
   - No, this PR does not affect any public API so no need to change the 
documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to