petern48 commented on code in PR #2270:
URL: https://github.com/apache/sedona/pull/2270#discussion_r2268240475
##########
python/sedona/spark/geopandas/geodataframe.py:
##########
@@ -810,12 +810,10 @@ def copy(self, deep=False):
geometry value1 value2
0 POINT (1 1) 2 3
"""
- if deep:
- return GeoDataFrame(
- self._anchor.copy(), dtype=self.dtypes, index=self._col_label
- )
- else:
- return self # GeoDataFrame(self._internal.spark_frame.copy())
"this parameter is not supported but just dummy parameter to match pandas."
+ # Note: The deep parameter is a dummy parameter just as it is in
PySpark pandas
Review Comment:
I don't see a need personally. PySpark pandas does the same behavior. No
warning or exception. Effectively it behaves similar to a deep copy of a python
object, since pyspark is forced to create new immutable dataframes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
