jiayuasu commented on code in PR #2260:
URL: https://github.com/apache/sedona/pull/2260#discussion_r2267977041
##########
spark/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/st_constructors.scala:
##########
@@ -108,6 +108,9 @@ object st_constructors {
wrapExpression[ST_GeogFromWKB](wkb, srid)
def ST_GeogFromWKB(wkb: String, srid: Int): Column =
wrapExpression[ST_GeogFromWKB](wkb, srid)
+ def ST_GeogFromEWKB(wkb: Column): Column =
wrapExpression[ST_GeogFromEWKB](wkb, 0)
+ def ST_GeogFromEWKB(wkb: String): Column =
wrapExpression[ST_GeogFromEWKB](wkb, 0)
Review Comment:
I think copilot is right. Your DataFrame API implementation here always
overrides the SRID in EWKB to be 0. This is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
