Copilot commented on code in PR #2119:
URL: https://github.com/apache/sedona/pull/2119#discussion_r2217108403
##########
python/sedona/geopandas/geoseries.py:
##########
@@ -45,9 +45,274 @@
)
+# ============================================================================
+# IMPLEMENTATION STATUS TRACKING
+# ============================================================================
+
+IMPLEMENTATION_STATUS = {
+ "IMPLEMENTED": [
+ "area",
+ "buffer",
+ "bounds",
+ "centroid",
+ "crs",
+ "distance",
+ "envelope",
+ "geometry",
+ "intersection",
+ "intersects",
+ "is_empty",
+ "is_simple",
+ "is_valid",
+ "is_valid_reason",
+ "length",
+ "make_valid",
+ "set_crs",
+ "to_crs",
+ "to_geopandas",
+ "to_wkb",
+ "to_wkt",
+ "x",
+ "y",
+ "z",
+ "has_z",
+ "get_geometry",
+ "boundary",
+ "total_bounds",
+ "estimate_utm_crs",
+ "fillna",
+ "isna",
+ "isnull",
+ "notna",
+ "notnull",
+ "from_wkb",
+ "from_wkt",
+ "from_xy",
+ "copy",
+ "geom_type",
+ "sindex",
+ ],
+ "NOT_IMPLEMENTED": [
+ "clip",
+ "contains",
+ "contains_properly",
+ "convex_hull",
+ "count_coordinates",
+ "count_geometries",
+ "count_interior_rings",
+ "explode",
+ "force_2d",
+ "force_3d",
+ "from_file",
+ "from_shapely",
+ "from_arrow",
+ "line_merge",
+ "reverse",
+ "segmentize",
+ "to_json",
+ "to_arrow",
+ "to_file",
+ "transform",
+ "unary_union",
+ "union_all",
+ "intersection_all",
+ "type",
+ "is_ring",
+ "is_ccw",
+ "is_closed",
+ "get_precision",
+ "concave_hull",
+ "delaunay_triangles",
+ "voronoi_polygons",
+ "minimum_rotated_rectangle",
+ "exterior",
+ "extract_unique_points",
+ "offset_curve",
+ "interiors",
+ "remove_repeated_points",
+ "set_precision",
+ "representative_point",
+ "minimum_bounding_circle",
+ "minimum_bounding_radius",
+ "minimum_clearance",
+ "normalize",
+ "m",
+ ],
+ "PARTIALLY_IMPLEMENTED": [
+ "fillna", # Limited parameter support (no 'limit' parameter)
Review Comment:
The comment indicates limited parameter support for 'fillna', but this
method is also listed in the IMPLEMENTED section (line 83). This creates
confusion about the actual implementation status. Consider moving this to a
separate category or clarifying the implementation status.
##########
python/sedona/geopandas/geoseries.py:
##########
@@ -45,9 +45,274 @@
)
+# ============================================================================
+# IMPLEMENTATION STATUS TRACKING
+# ============================================================================
+
+IMPLEMENTATION_STATUS = {
+ "IMPLEMENTED": [
+ "area",
+ "buffer",
+ "bounds",
+ "centroid",
+ "crs",
+ "distance",
+ "envelope",
+ "geometry",
+ "intersection",
+ "intersects",
+ "is_empty",
+ "is_simple",
+ "is_valid",
+ "is_valid_reason",
+ "length",
+ "make_valid",
+ "set_crs",
+ "to_crs",
+ "to_geopandas",
+ "to_wkb",
+ "to_wkt",
+ "x",
+ "y",
+ "z",
+ "has_z",
+ "get_geometry",
+ "boundary",
+ "total_bounds",
+ "estimate_utm_crs",
+ "fillna",
+ "isna",
+ "isnull",
+ "notna",
+ "notnull",
+ "from_wkb",
+ "from_wkt",
+ "from_xy",
+ "copy",
+ "geom_type",
+ "sindex",
+ ],
+ "NOT_IMPLEMENTED": [
+ "clip",
+ "contains",
+ "contains_properly",
+ "convex_hull",
+ "count_coordinates",
+ "count_geometries",
+ "count_interior_rings",
+ "explode",
+ "force_2d",
+ "force_3d",
+ "from_file",
+ "from_shapely",
+ "from_arrow",
+ "line_merge",
+ "reverse",
+ "segmentize",
+ "to_json",
+ "to_arrow",
+ "to_file",
+ "transform",
+ "unary_union",
+ "union_all",
+ "intersection_all",
+ "type",
+ "is_ring",
+ "is_ccw",
+ "is_closed",
+ "get_precision",
+ "concave_hull",
+ "delaunay_triangles",
+ "voronoi_polygons",
+ "minimum_rotated_rectangle",
+ "exterior",
+ "extract_unique_points",
+ "offset_curve",
+ "interiors",
+ "remove_repeated_points",
+ "set_precision",
+ "representative_point",
+ "minimum_bounding_circle",
+ "minimum_bounding_radius",
+ "minimum_clearance",
+ "normalize",
+ "m",
+ ],
+ "PARTIALLY_IMPLEMENTED": [
+ "fillna", # Limited parameter support (no 'limit' parameter)
+ "from_wkb",
+ "from_wkt", # Limited error handling options (only 'raise' supported)
Review Comment:
The method 'from_wkt' is listed in both IMPLEMENTED (line 89) and
PARTIALLY_IMPLEMENTED sections, creating inconsistency in the implementation
status tracking.
##########
python/sedona/geopandas/geodataframe.py:
##########
@@ -43,9 +43,270 @@
register_extension_dtype(GeometryDtype)
+# ============================================================================
+# IMPLEMENTATION STATUS TRACKING
+# ============================================================================
+
+IMPLEMENTATION_STATUS = {
+ "IMPLEMENTED": [
+ "area",
+ "buffer",
+ "crs",
+ "geometry",
+ "active_geometry_name",
+ "sindex",
+ "set_geometry",
+ "rename_geometry",
+ "copy",
+ "sjoin",
+ "to_parquet",
+ "_get_geometry",
+ "_set_geometry",
+ "_process_geometry_columns",
+ "_safe_get_crs",
+ ],
+ "NOT_IMPLEMENTED": [
+ "to_geopandas",
+ "_to_geopandas",
+ "geom_type",
+ "type",
+ "length",
+ "is_valid",
+ "is_valid_reason",
+ "is_empty",
+ "is_simple",
+ "is_ring",
+ "is_ccw",
+ "is_closed",
+ "has_z",
+ "boundary",
+ "centroid",
+ "convex_hull",
+ "envelope",
+ "exterior",
+ "interiors",
+ "unary_union",
+ "count_coordinates",
+ "count_geometries",
+ "count_interior_rings",
+ "get_precision",
+ "get_geometry",
+ "concave_hull",
+ "delaunay_triangles",
+ "voronoi_polygons",
+ "minimum_rotated_rectangle",
+ "extract_unique_points",
+ "offset_curve",
+ "remove_repeated_points",
+ "set_precision",
+ "representative_point",
+ "minimum_bounding_circle",
+ "minimum_bounding_radius",
+ "minimum_clearance",
+ "normalize",
+ "make_valid",
+ "reverse",
+ "segmentize",
+ "transform",
+ "force_2d",
+ "force_3d",
+ "line_merge",
+ "union_all",
+ "intersection_all",
+ "contains",
+ "contains_properly",
+ ],
+ "PARTIALLY_IMPLEMENTED": ["set_geometry"], # Only drop=True case is not
implemented
Review Comment:
The method 'set_geometry' is listed in both IMPLEMENTED (line 58) and
PARTIALLY_IMPLEMENTED sections, creating inconsistency in the implementation
status tracking.
##########
python/sedona/geopandas/geoseries.py:
##########
@@ -45,9 +45,274 @@
)
+# ============================================================================
+# IMPLEMENTATION STATUS TRACKING
+# ============================================================================
+
+IMPLEMENTATION_STATUS = {
+ "IMPLEMENTED": [
+ "area",
+ "buffer",
+ "bounds",
+ "centroid",
+ "crs",
+ "distance",
+ "envelope",
+ "geometry",
+ "intersection",
+ "intersects",
+ "is_empty",
+ "is_simple",
+ "is_valid",
+ "is_valid_reason",
+ "length",
+ "make_valid",
+ "set_crs",
+ "to_crs",
+ "to_geopandas",
+ "to_wkb",
+ "to_wkt",
+ "x",
+ "y",
+ "z",
+ "has_z",
+ "get_geometry",
+ "boundary",
+ "total_bounds",
+ "estimate_utm_crs",
+ "fillna",
+ "isna",
+ "isnull",
+ "notna",
+ "notnull",
+ "from_wkb",
+ "from_wkt",
+ "from_xy",
+ "copy",
+ "geom_type",
+ "sindex",
+ ],
+ "NOT_IMPLEMENTED": [
+ "clip",
+ "contains",
+ "contains_properly",
+ "convex_hull",
+ "count_coordinates",
+ "count_geometries",
+ "count_interior_rings",
+ "explode",
+ "force_2d",
+ "force_3d",
+ "from_file",
+ "from_shapely",
+ "from_arrow",
+ "line_merge",
+ "reverse",
+ "segmentize",
+ "to_json",
+ "to_arrow",
+ "to_file",
+ "transform",
+ "unary_union",
+ "union_all",
+ "intersection_all",
+ "type",
+ "is_ring",
+ "is_ccw",
+ "is_closed",
+ "get_precision",
+ "concave_hull",
+ "delaunay_triangles",
+ "voronoi_polygons",
+ "minimum_rotated_rectangle",
+ "exterior",
+ "extract_unique_points",
+ "offset_curve",
+ "interiors",
+ "remove_repeated_points",
+ "set_precision",
+ "representative_point",
+ "minimum_bounding_circle",
+ "minimum_bounding_radius",
+ "minimum_clearance",
+ "normalize",
+ "m",
+ ],
+ "PARTIALLY_IMPLEMENTED": [
+ "fillna", # Limited parameter support (no 'limit' parameter)
+ "from_wkb",
Review Comment:
The method 'from_wkb' is listed in both IMPLEMENTED (line 88) and
PARTIALLY_IMPLEMENTED sections, creating inconsistency in the implementation
status tracking.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
