james-willis commented on PR #1774: URL: https://github.com/apache/sedona/pull/1774#issuecomment-2616811520
> Please consider reusing the logic if possible Thanks Jia. I was thinking that these functions I created would be useful for Physical Nodes but the linked code reminds me that InternalRows/UnsafeRows are used in these Physical Nodes, whereas the functions in this PR are for Rows. While you can convert between Rows and InternalRows, its an unnecessary conversion. It is probably best to keep distinct implementations for these two interfaces. The fact that the implementations here are only useful for RDD[Row] but not RDD[InternalRow] makes me wonder if these are useful enough to introduce into the Sedona API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
