Kontinuation commented on code in PR #1704:
URL: https://github.com/apache/sedona/pull/1704#discussion_r1859755917


##########
pom.xml:
##########
@@ -165,6 +165,20 @@
                 <artifactId>cdm-core</artifactId>
                 <version>${cdm.version}</version>
                 <scope>${cdm.scope}</scope>
+                <exclusions>
+                    <exclusion>
+                        <groupId>com.google.guava</groupId>
+                        <artifactId>guava</artifactId>
+                    </exclusion>
+                    <exclusion>
+                        <groupId>org.apache.httpcomponents</groupId>
+                        <artifactId>httpclient</artifactId>
+                    </exclusion>
+                    <exclusion>
+                        <groupId>com.google.protobuf</groupId>
+                        <artifactId>protobuf-java</artifactId>
+                    </exclusion>

Review Comment:
   Note: `protobuf-java` became shaded since Spark 3.5 
([SPARK-41244](https://issues.apache.org/jira/browse/SPARK-41244)). However, 
protobuf is only used for the experimental [NetCDF streaming 
format](https://docs.unidata.ucar.edu/netcdf-java/5.6/userguide/ncstream.html) 
so excluding it won't affect our NetCDF support. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to