jojochuang opened a new pull request, #1588: URL: https://github.com/apache/ratis/pull/1588
## Summary - For ordered gRPC Raft RPCs (`ServerRequestStreamObserver` with `replyInOrder == true`, including INSTALL_SNAPSHOT), each reply is sent on the stream in `onNext`, but the internal `CompletableFuture` chain completes with `null`. - `onCompleted` logged `ProtoUtils.shortDebugString(reply)` and therefore always showed `lastReply: null`, which is misleading during snapshot catch-up. - Record the last reply sent on the stream and log it with `replyToString` on stream completion (fallback to the future value for unordered requests, or `none`). ## Jira https://issues.apache.org/jira/browse/RATIS-2694 ## Test plan - [x] `mvn -pl ratis-grpc -am test -DskipTests` - [ ] Manual: SCM/OM HA follower install snapshot — `Completed INSTALL_SNAPSHOT, lastReply:` should match the last `reply installSnapshot:` line from `SnapshotInstallationHandler` Made with [Cursor](https://cursor.com) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
