HTHou commented on PR #1577: URL: https://github.com/apache/ratis/pull/1577#issuecomment-5577808146
Thanks @szetszwo! Updated in 80b96f6d6. - Scoped this PR to AppendEntries and moved its callbacks into the AppendEntries sub-interface. InstallSnapshot callbacks/tests are removed for a follow-up. - Each callback now has one invocation site. Removed the unused constructor and included both peer identities in factory-failure logs. - Kept two small safeguards around the suggested structure: exceptions from appendEntries() are isolated, and onNotRunning runs in finally so exceptional appender exits are also observable. - Named the parent callback onReset rather than onResetClient: INCONSISTENCY handling also discards pending requests without resetting the client. The same notification helper runs under the appender write lock at both reset sites, avoiding lost outstanding attempts or application-side tracking leaks. - Added LOG_APPENDER_LISTENER_FACTORY_CLASS to fix TestConfUtils and retained the stopped/stepped-down stream-callback regression. 22 targeted tests, Checkstyle, SpotBugs and RAT pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
