dimas-b commented on code in PR #4064:
URL: https://github.com/apache/polaris/pull/4064#discussion_r3067170635
##########
runtime/service/src/main/java/org/apache/polaris/service/events/PolarisServiceBusEventDispatcher.java:
##########
@@ -40,6 +41,11 @@ public class PolarisServiceBusEventDispatcher implements
PolarisEventDispatcher
*/
@Override
public void dispatch(PolarisEvent event) {
- eventBus.publish(POLARIS_EVENT_CHANNEL, event);
+ eventBus.publish(POLARIS_EVENT_CHANNEL + "." + event.type(), event);
Review Comment:
nit: would it be reasonable to double check that the event type is enabled?
I suppose the overhead is not huge, but the benefit is safeguarding against
mistakes in enabled checks at call sites 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
